chore: float launchdarkly-server-sdk within its current major - #36
Merged
Merged
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
Author
|
@cursor review |
keelerm84
approved these changes
Sep 21, 2026
tanderson-ld
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bounds the SDK dependency to the 9.x major so
poetry installkeeps picking up the latest 9.x release but can't silently jump to a future 10.0.0 with breaking changes.launchdarkly-server-sdk = ">=9.16.0"→">=9.16.0,<10.0.0"; floor unchanged, still resolves to 9.17.0.halo = ">=0.0.3"left alone: 0.x minors are breaking, so a<1.0.0cap isn't the right idiom here.python = "^3.10"and the README's documented "Python 3.10 or higher" minimum untouched (SDK 9.17.0 still requires>=3.10).Implementation details
Verification on this branch (Python 3.12, Poetry 2.5.1):
poetry installresolveslaunchdarkly-server-sdk 9.17.0(latest 9.x) +launchdarkly-eventsource 1.7.3,halo 0.0.31;poetry.lockis gitignored, so nothing to regenerate in-tree.LAUNCHDARKLY_FLAG_KEY=hello-boolean:CI=1 poetry run python -W error::DeprecationWarning main.py→*** SDK successfully initialized/*** The hello-boolean feature flag evaluates to True+ banner, exit 0.CI) also initializes and evaluates; the only deprecation surfaced is upstreamhalo/halo.py:497 setDaemon() is deprecated, not our code.DeprecationWarninginldclient9.17.0 isConfig.copy_with_new_sdk_key, which the example does not use.set_config,ldclient.get(),variation,flag_tracker.add_flag_value_change_listener, andContext.builderare all current.>=9.16.0unbounded (contradicts the float-within-major policy);^9.16.0(equivalent for 9.x but the repo already uses>=-style constraints); raising the floor to 9.17.0 (unnecessary — the constraint already permits latest).checkout@v7,setup-python@v7.0.0,abatilo/actions-poetry@3765cf6,verify-hello-app-v2.0.1) are all already latest and deliberately pinned; untouched.Link to Devin session: https://app.devin.ai/sessions/060a05cf5a56488ca7025fc0cdfd433f
Open in Devin Desktop: https://app.devin.ai/desktop/session/060a05cf5a56488ca7025fc0cdfd433f?variant=devin
Note
Overview
Caps
launchdarkly-server-sdkinpyproject.tomlso Poetry still accepts 9.16.0+ but won't resolve a future 10.x release. The minimum version is unchanged; installs continue to float within the current major (e.g. 9.17.0).No application or CI workflow changes—only the dependency constraint.
Reviewed by Cursor Bugbot for commit 50fe83f. Bugbot is set up for automated code reviews on this repo. Configure here.